Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: upload check label when monitor empty #3661

Merged
merged 5 commits into from
May 19, 2024

Conversation

guguji5
Copy link
Contributor

@guguji5 guguji5 commented Aug 30, 2023

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

As the title described, this PR adds check label in flashduty which is a important one to display and distinguish.

Type of change

Please delete any options that are not relevant.

  • Other

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas
    (including JSDoc for methods)
  • My changes generate no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.

Copy link
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a reasonable change.

server/notification-providers/flashduty.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that while it is less likely that the change would cause a merge conflict with weblate, please still add your translation changes in weblate (once this is in master ^^) to avoid conflicts

src/lang/yue.json Outdated Show resolved Hide resolved
src/lang/zh-CN.json Outdated Show resolved Hide resolved
@louislam louislam added this to the 2.0.0 milestone Oct 11, 2023
@louislam
Copy link
Owner

I would like to re-confirm that, is it not a breaking change?

@louislam louislam added the question Further information is requested label Oct 11, 2023
@louislam louislam modified the milestones: 2.0.0, 2.1.0 Nov 23, 2023
@guguji5
Copy link
Contributor Author

guguji5 commented Jan 10, 2024

I would like to re-confirm that, is it not a breaking change?

not some big change, just adjust params to send.

@CommanderStorm CommanderStorm modified the milestones: 2.1.0, 2.0.0 May 19, 2024
@CommanderStorm
Copy link
Collaborator

Thanks for the enhancement!

All changes in this PR are small and uncontroversial ⇒ merging with junior maintainer approval

@CommanderStorm CommanderStorm added pr:needs review this PR needs a review by maintainers or other community members area:notifications Everything related to notifications type:enhance-existing feature wants to enhance existing monitor and removed pr:needs review this PR needs a review by maintainers or other community members labels May 19, 2024
@CommanderStorm CommanderStorm merged commit 168d1ca into louislam:master May 19, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:notifications Everything related to notifications question Further information is requested type:enhance-existing feature wants to enhance existing monitor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants